password reveal button is confusing if websites implement their own show/hide button [40654543]

Fixed

Bug

Status Update

No update yet.

Description

sh...@microsoft.com

created issue #1

Oct 22, 2019 05:35PM

See attached for two examples. The first, from airbnb, shows their own eye icon (looks like a closed eye with eyelashes) next to the new provided icon. The second, from Gmail, shows an even worse situation, where Gmail decided to use the opposite polarity on the site-provided icon, and they contradict each other

airbnb.png

59 KB

View

Download

gmail.png

61 KB

View

Download

Comments

sh...@microsoft.com <sh...@microsoft.com> #2Oct 22, 2019 05:36PM

[Empty comment from Monorail migration]

[Deleted User] <[Deleted User]> #3Oct 22, 2019 06:17PM

skihken@, thanks for filing this bug. I had forgotten the history on the CL - please see [1] for more discussion on this.

With the internally-prefixed selector, sites can't disable (or otherwise style) the reveal button. It would seem that we should work to standardize a ::reveal selector. Something like [2]. In the meantime, due to the compat issues in

https://crbug.com/chromium/1016844#c0, it would seem that we should disable the reveal button in Chromium for now.

[1]

https://chromium-review.googlesource.com/c/chromium/src/+/1708748
[2]

https://developer.mozilla.org/en-US/docs/Web/CSS/::-ms-reveal

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #4Oct 25, 2019 10:42PM

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/990279d277704c1506f8010e38cc89165188972f

commit 990279d277704c1506f8010e38cc89165188972f
Author: Alex Keng <shihken@microsoft.com>
Date: Fri Oct 25 22:40:27 2019

Password: Add an option to enable the Reveal button on password inputs

This CL adds a new flag, PasswordReveal, so the reveal button can be enabled later
when ::reveal gets standardized.

Bug: 1016844
Change-Id: Ic4d73b5e08c0ee2c9fc554f0f2e7331b4663e89b
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/1877141
Commit-Queue: Alex Keng <shihken@microsoft.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709674}

[modify]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/renderer/core/html/forms/password_input_type.cc
[modify]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/linux/virtual/controls-refresh-high-contrast/fast/forms/controls-new-ui-high-contrast/text_number_password_button_submit-expected.png
[modify]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/linux/virtual/controls-refresh/fast/forms/controls-new-ui/password/password-alt-f8-expected.png
[modify]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/mac-mac10.10/virtual/controls-refresh-high-contrast/fast/forms/controls-new-ui-high-contrast/text_number_password_button_submit-expected.png
[add]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/mac-mac10.10/virtual/controls-refresh/fast/forms/controls-new-ui/password/password-alt-f8-expected.png
[add]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/mac-mac10.11/virtual/controls-refresh-high-contrast/fast/forms/controls-new-ui-high-contrast/text_number_password_button_submit-expected.png
[add]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/mac-mac10.11/virtual/controls-refresh/fast/forms/controls-new-ui/password/password-alt-f8-expected.png
[add]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/mac-mac10.12/virtual/controls-refresh-high-contrast/fast/forms/controls-new-ui-high-contrast/text_number_password_button_submit-expected.png
[add]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/mac-mac10.12/virtual/controls-refresh/fast/forms/controls-new-ui/password/password-alt-f8-expected.png
[add]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/mac-retina/virtual/controls-refresh-high-contrast/fast/forms/controls-new-ui-high-contrast/text_number_password_button_submit-expected.png
[add]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/mac-retina/virtual/controls-refresh/fast/forms/controls-new-ui/password/password-alt-f8-expected.png
[add]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/mac/virtual/controls-refresh-high-contrast/fast/forms/controls-new-ui-high-contrast/text_number_password_button_submit-expected.png
[modify]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/mac/virtual/controls-refresh/fast/forms/controls-new-ui/password/password-alt-f8-expected.png
[modify]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/mac/virtual/controls-refresh/fast/forms/controls-new-ui/password/password-alt-f8-twice-expected.png
[modify]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/win/virtual/controls-refresh-high-contrast/fast/forms/controls-new-ui-high-contrast/text_number_password_button_submit-expected.png
[modify]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/win/virtual/controls-refresh/fast/forms/controls-new-ui/password/password-alt-f8-expected.png
[modify]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/win/virtual/controls-refresh/fast/forms/controls-new-ui/password/password-alt-f8-twice-expected.png
[modify]

https://crrev.com/41c13f0009cf8d92025fa16136afbae94862f4f1/third_party/blink/web_tests/platform/win/virtual/controls-refresh/fast/forms/controls-new-ui/password/password-eye-icon-zoom-4x-expected.png
[modify]

https://crrev.com/990279d277704c1506f8010e38cc89165188972f/third_party/blink/web_tests/platform/win7/virtual/controls-refresh-high-contrast/fast/forms/controls-new-ui-high-contrast/text_number_password_button_submit-expected.png

[Deleted User] <[Deleted User]> #5Nov 4, 2019 06:24PM

With the CL in

https://crbug.com/chromium/1016844#c3, this bug is "fixed" - correct? Or at least the Reveal button is disabled by default, which removes the confusion. Perhaps there is a follow-up bug to re-enable it with a spec'd and non-prefixed pseudo-element, but that sounds like a different bug.

sh...@microsoft.com <sh...@microsoft.com> #6Nov 4, 2019 10:08PM

Marked as fixed.

correct, the reveal button is disabled by default upstream. Change this this bug to "fixed", thanks!

pc...@microsoft.com <pc...@microsoft.com> #7Dec 5, 2019 04:46AM

[Empty comment from Monorail migration]

is...@google.com <is...@google.com> #8Dec 5, 2019 04:46AM

This issue was migrated from

crbug.com/chromium/1016844?no_tracker_redirect=1

[Monorail blocking:

crbug.com/chromium/1012106,

crbug.com/chromium/1012108]
[Monorail components added to Component Tags custom field.]